• jol@discuss.tchncs.de
    link
    fedilink
    arrow-up
    150
    ·
    4 months ago

    I mean, you’re not hired to “code”, you’re hired to do software engineering. That usually means working with other people. Reviewing code is a win win situation because both get a second pair of eyes on their code and prevent each other from committing dumb shit that you might have to fix later.

    I feel like these memes of hating everything other than lone coding is because you keep working for toxic companies. Ffs you’re programmers, it’s probably super easy to get another job. It doesn’t have to be like this.

    • rockSlayer@lemmy.world
      link
      fedilink
      arrow-up
      26
      ·
      4 months ago

      I think QA engineering needs to become more widespread. The “extra pair of eyes” can’t compare to a department of people dedicated to code review and testing.

      • jol@discuss.tchncs.de
        link
        fedilink
        arrow-up
        30
        ·
        4 months ago

        QA and Code reviews do different jobs. Manual and automated testing will not notice your code is shit, so long as all test cases pass.

        • rockSlayer@lemmy.world
          link
          fedilink
          arrow-up
          7
          ·
          4 months ago

          That’s what QA engineering is for. They are integrated into the dev team and they pull double duty with QA and code review.

          • jol@discuss.tchncs.de
            link
            fedilink
            arrow-up
            11
            ·
            4 months ago

            In my company QA is dedicated to manual and automated tests. I haven’t met many QA engineers who could effectively review any of my code.

                • rockSlayer@lemmy.world
                  link
                  fedilink
                  arrow-up
                  1
                  ·
                  4 months ago

                  A title is just something a company calls a particular job. A role is what that job actually is. So a lot of jobs might be called “QA engineer”, but not fitting the intended role

                  • jol@discuss.tchncs.de
                    link
                    fedilink
                    arrow-up
                    2
                    ·
                    4 months ago

                    Gotcha. I mean, all software engineers should do some QA engineering, but we have QA engineers who are the experts and “QA coaches”.

            • Marketsupreme@lemm.ee
              link
              fedilink
              arrow-up
              2
              ·
              4 months ago

              As a qa engineer this makes me feel better about myself. Because I’m included on reviews but never know what I’m looking at.

              • jol@discuss.tchncs.de
                link
                fedilink
                arrow-up
                2
                ·
                4 months ago

                I’ve worked in places where QA we people with no coding knowledge who just clicked around looking for bugs, as well as places where QA never did that, only automated tests. And then there are places that believe hiring QA is useless, because “everyone should do QA”.

                • Marketsupreme@lemm.ee
                  link
                  fedilink
                  arrow-up
                  1
                  ·
                  4 months ago

                  This is my first big career job and in my limited experience I think I support the idea of a second pair of eyes, with a hybrid on automated testing. It seems more comprehensive and thorough than having a single person work on a task (minus code reviews).

      • Windex007@lemmy.world
        link
        fedilink
        arrow-up
        14
        ·
        4 months ago

        You don’t want a department that you throw it over the fence to, you want them embedded on your team. Keep those feedback loops TIGHT bois

      • SpaceNoodle@lemmy.world
        link
        fedilink
        arrow-up
        3
        ·
        4 months ago

        Dedicated to testing, absolutely, but they don’t necessarily require expertise regarding implementation.

    • Fubber Nuckin'@lemmy.world
      link
      fedilink
      arrow-up
      4
      ·
      4 months ago

      Ffs you’re programmers, it’s probably super easy to get another job. It doesn’t have to be like this.

      Who’s gonna tell them?